Skip to content

Focus style fixes #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 9, 2024
Merged

Focus style fixes #1560

merged 21 commits into from
Sep 9, 2024

Conversation

dariiing
Copy link
Contributor

@dariiing dariiing commented Jul 11, 2024 •
edited
Loading

Hello,
This PR aims to fix design inconsistencies across the entire app: #1506
Pages targeted in this PR are:

  • drive
  • calendar
  • home page
  • teams page
  • settings
  • documents ( fixed document titles)
  • admin page
  • features page

@dariiing dariiing added the Accessibility Make software available to everyone label Jul 11, 2024
@dariiing dariiing added this to the Autumn release (2024.9.0) milestone Jul 11, 2024
@dariiing dariiing self-assigned this Jul 11, 2024
@dariiing dariiing marked this pull request as draft July 15, 2024 13:53
@dariiing dariiing added the Ready to Review This PR is ready to be checked by another team member label Aug 19, 2024
@dariiing dariiing marked this pull request as ready for review August 19, 2024 10:44
davidbenque
davidbenque reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@davidbenque davidbenque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-08-22 11-22-45

There is an issue with the subscribe button on the instance home page when the accounts app is enabled

@davidbenque
Copy link
Contributor

davidbenque commented Aug 22, 2024 •
edited
Loading

Discovered while testing this, but it may be out of scope

@davidbenque davidbenque removed the Ready to Review This PR is ready to be checked by another team member label Aug 22, 2024
@dariiing dariiing added the Ready to Review This PR is ready to be checked by another team member label Aug 26, 2024
@yflory yflory added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Sep 3, 2024
@yflory yflory merged commit 8f9ba40 into staging Sep 9, 2024
@dariiing dariiing deleted the focus-style-fixes branch September 11, 2024 11:27
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbenque davidbenque davidbenque approved these changes

Assignees

@dariiing dariiing

Labels
Accessibility Make software available to everyone
Projects
None yet
Milestone
Autumn release (2024.9.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@dariiing @davidbenque @yflory