Skip to content

TypeError in read-only sheet trying to encrypt #1364

@ansuz

Description

@ansuz

Description

It is possible for CryptPad's read-only sheets (and presumably other OnlyOffice-based apps) to invoke a SEND_MESSAGE command via the Q_OO_COMMAND handler, found here.

When this occurs it tries to encrypt a message, but Utils.crypto.encrypt is undefined, resulting in a TypeError.

Steps to reproduce

I haven't isolated a minimal set of steps to reproduce it, but I've observed the error while viewing a read-only version of a sheet in a private window while saving edits made in strict mode in a regular session.

Minimal changes to particular cells didn't seem to trigger it, while more complex changes like inserting a column in a worksheet or reconfiguring a chart did.

Relevant logs

No response

Expected behavior

read-only sheets should abort sending outgoing messages some time before they trigger a TypeError.

What opreating system are you using?

Linux/BSD/UNIX

What browsers are you seeing the problem on?

Mozilla Firefox

Extensions

private Firefox window with all extensions disabled

Version

5.6.0

Metadata

Metadata

Assignees

Labels

BugThere is a problem in our source codeFixed in stagingThis is live on staging branchSpreadsheetRelated to the Spreadsheet app

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions