fix KeyModifiers Display impl #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flokkq <webcla21@htl-kaindorf.at>
- only tested on macos! Signed-off-by: Flokkq <webcla21@htl-kaindorf.at>
Flokkq
added a commit
to Flokkq/ryvex
that referenced
this pull request
Mar 22, 2025
found a bug in crossterm while implementing lol crossterm-rs/crossterm#979 Signed-off-by: Flokkq <webcla21@htl-kaindorf.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KeyModifiers Display impl
Issue:
The
KeyModifiersDisplayimplementation incorrectly formats modifier keys due to a misplaced flag, causing the output to be concatenated without+separators.Current output:
"ShiftControlOption"Expected output:
"Shift+Control+Option"Fix:
first = false;outside the if condition to ensure separator placement after the first iteration