Skip to content

use image from main in test for cross dind test #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

use image from main in test for cross dind test #924

merged 1 commit into from
Jul 8, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner July 8, 2022 15:36
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jul 8, 2022
Alexhuszagh
Alexhuszagh requested changes Jul 8, 2022
View reviewed changes
@Emilgardis Emilgardis force-pushed the cross-image-release-fix branch from c516f04 to 1bc6254 Compare July 8, 2022 16:23
@Alexhuszagh
Copy link
Contributor

You should probably use declare -x rather than this, but it still works on my end.

@Emilgardis Emilgardis force-pushed the cross-image-release-fix branch from 1bc6254 to 75b7354 Compare July 8, 2022 16:40
@Emilgardis
Copy link
Member Author

switched to declare

bors r=@Alexhuszagh

bors bot added a commit that referenced this pull request Jul 8, 2022
@bors @Emilgardis
Merge #924
9a5f203 
924: use image from main in test for cross dind test r=Alexhuszagh a=Emilgardis



Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@Emilgardis
Copy link
Member Author

bors cancel

shellcheck is not happy

@bors
Copy link
Contributor

bors bot commented Jul 8, 2022

Canceled.

@Emilgardis Emilgardis force-pushed the cross-image-release-fix branch 2 times, most recently from 018f166 to ae82561 Compare July 8, 2022 16:45
@Emilgardis
Copy link
Member Author

Emilgardis commented Jul 8, 2022 •
edited
Loading

and switched back, don't see the reason for using declare (+ I used it wrong :) )

@Alexhuszagh
Copy link
Contributor

and switched back, seems don't see the reason for using declare (+ I used it wrong :) )

No worries as long as shellcheck passes and the code works.

@Emilgardis Emilgardis force-pushed the cross-image-release-fix branch from ae82561 to 60b44b8 Compare July 8, 2022 16:47
@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 8, 2022

Build succeeded:

@bors bors bot merged commit ca16d4a into cross-rs:main Jul 8, 2022
@Emilgardis Emilgardis mentioned this pull request Jul 8, 2022
Merged
Emilgardis added a commit to Emilgardis/cross that referenced this pull request Jul 8, 2022
@Emilgardis
fix dind test
978b381 
same as cross-rs#924
Emilgardis added a commit to Emilgardis/cross that referenced this pull request Jul 8, 2022
@Emilgardis
fix dind test
258701a 
same as cross-rs#924

also fixes no subs on variable passthrough
bors bot added a commit that referenced this pull request Jul 8, 2022
@bors @Emilgardis
Merge #925
3d6a52a 
925: fix dind test r=Alexhuszagh a=Emilgardis

same as #924

also fixes no subs on variable passthrough


Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh