Skip to content

xtask #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2022
Merged

xtask #788

merged 3 commits into from
Jun 13, 2022

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Jun 13, 2022 •
edited
Loading

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner June 13, 2022 17:04
Emilgardis
Emilgardis commented Jun 13, 2022
View reviewed changes
Copy link
Member Author

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors @Emilgardis
Merge #788
4835d83 
788: xtask r=Emilgardis a=Emilgardis

- rename `cross-dev` -> `xtask`
- fix logic error when in GHA


Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@Emilgardis
Copy link
Member Author

bors r-

one more bug

@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

Canceled.

@Emilgardis Emilgardis force-pushed the xtask branch 2 times, most recently from e81ef2c to e69ed65 Compare June 13, 2022 17:22
@Emilgardis
rename cross-dev -> xtask
66bf016 
also makes it it's own workspace member, meaning it can have its own dependencies.

This does mean however that it does not make much sense to install it.
@Emilgardis
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors
Try #788:
c200632
Alexhuszagh
Alexhuszagh reviewed Jun 13, 2022
View reviewed changes
Copy link
Contributor

@Alexhuszagh Alexhuszagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides wondering if we still need cross-dev.

@Alexhuszagh
Copy link
Contributor

Can I merge or do you want to squash the commits into 1?

@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member Author

I have no preference

@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

Build succeeded:

@bors bors bot merged commit cf582ce into cross-rs:main Jun 13, 2022
@Emilgardis Emilgardis deleted the xtask branch June 14, 2022 15:31
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no-ci-targets PRs that do not affect or should skip any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
meta issues/PRs related to the maintenance of the crate. no-ci-targets PRs that do not affect or should skip any cross-compilation targets.
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh