Allow variable definitions in env.pasthrough. #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the following syntax: ```toml [build.env] passthrough = ["VAR=VALUE"] ```
otavio
approved these changes
Jun 3, 2022
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jun 3, 2022
750: Allow key-value pairs in config volumes. r=otavio a=Alexhuszagh Allow volumes to use the `["VOL=/path/to/volume"]' syntax as well, so additional mount points can be defined by value in the `env.volumes` section of the config file. Allows the following syntax: ```toml [build.env] volumes = ["VOL=/path/to/mount/"] ``` Not implementing it with the `env.passthrough` was a complete oversight on my part, related to #743 and #748. Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the following syntax:
Closes #743.