Skip to content

Remove explicit semver dependency #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2021
Merged

Remove explicit semver dependency #560

merged 1 commit into from
Aug 28, 2021

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented May 27, 2021

This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver.

@dtolnay dtolnay requested review from Dylan-DPC-zz and a team as code owners May 27, 2021 18:12
therealprof
therealprof approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

bors bot added a commit that referenced this pull request May 27, 2021
@bors @dtolnay
Merge #560
ca47fb2 
560: Remove explicit semver dependency r=therealprof a=dtolnay

This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver.

Co-authored-by: David Tolnay <dtolnay@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 27, 2021

Build failed:

@dtolnay
Copy link
Contributor Author

dtolnay commented May 28, 2021

Build failure appears unrelated.

+ python3 ./repo sync -c bionic
Traceback (most recent call last):
  File "/tmp/tmp.f0V4aSzo5t/.repo/repo/main.py", line 627, in <module>
    _Main(sys.argv[1:])
...
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ssh'
The command '/bin/sh -c /android-system.sh arm64' returned a non-zero code: 1

@therealprof
Copy link
Contributor

@dtolnay Yeah, I agree. 🙄

@reitermarkus
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jul 14, 2021
@bors @dtolnay
Merge #560
4416a7e 
560: Remove explicit semver dependency r=therealprof a=dtolnay

This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver.

Co-authored-by: David Tolnay <dtolnay@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2021

Build failed:

  • rust-embedded.cross

@adamgreig
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jul 25, 2021
@bors @dtolnay
Merge #560
786d0ae 
560: Remove explicit semver dependency r=therealprof a=dtolnay

This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver.

Co-authored-by: David Tolnay <dtolnay@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2021

Timed out.

@reitermarkus
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Aug 28, 2021
@bors @dtolnay
Merge #560
f58b14a 
560: Remove explicit semver dependency r=therealprof a=dtolnay

This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver.

Co-authored-by: David Tolnay <dtolnay@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 28, 2021

Build failed:

@Emilgardis
Copy link
Member

bors retry 🤞

@Emilgardis
Copy link
Member

I see now that in #554 we actually do depend on semver.

@bors
Copy link
Contributor

bors bot commented Aug 28, 2021

Build succeeded:

@bors bors bot merged commit d13df1a into cross-rs:master Aug 28, 2021
@dtolnay dtolnay deleted the semver branch August 28, 2021 19:51
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect or should skip any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect or should skip any cross-compilation targets.
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
6 participants
@dtolnay @therealprof @reitermarkus @adamgreig @Emilgardis @Alexhuszagh