Skip to content

bump linux-image version to fix CI #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2020
Merged

bump linux-image version to fix CI #498

merged 4 commits into from
Dec 12, 2020

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Dec 9, 2020

the Dockerfiles try to use linux-image-4.19.0-10 which no longer exists in the debian package repository; this is making CI fail: https://dev.azure.com/rust-embedded/cross/_build/results?buildId=772&view=logs&j=e6deedce-f53c-5dcc-524e-14349f140ffd&t=9e60ab89-47e0-5dc9-e657-a2fbb695cbf9&l=6521
this PR updates the package version (revision?) to linux-image-4.19.0-11

@japaric japaric requested review from Dylan-DPC-zz and a team as code owners December 9, 2020 10:23
@japaric
Copy link
Contributor Author

japaric commented Dec 9, 2020

rust-embedded.cross (aarch64-linux-android) Failing after 5m

the android builds are failing because the repo tool used in the android-system.sh script no longer supports python 2 which is what the Dockerfile is using. repo supports python 3.6+ and ubuntu 16.04 ships with python 3.5 so trying to use the python3 package doesn't work either. I tried to use an older snapshot of the repo tool (2.7-2.10) but those still don't work with python2 because the repo tool appears to execute some third party python code that's not python2 compatible.

@japaric
base android images on Ubuntu 20.04
9312b43 
the repo tool (all of its versions?) now depend on a python 3.6+ interpreter
Ubuntu 16.04 only has access to a python 3.5 interpreter which is too old and won't work
using a newer Ubuntu image shouldn't affect the minimum supported android version (*) because we are
building an android SDK from scratch and android doesn't depend on gliblc

(*) old Ubuntu images are used for the linux-gnu targets to ensure compatibility with old glibc
versions
@japaric
Copy link
Contributor Author

japaric commented Dec 9, 2020

ok, moved the android images to Ubuntu 20.04; that should fix the issues with the repo tool

basing those images on Ubuntu 20.04 (*) shouldn't raise the minimum supported android version because we are building an android SDK from scratch and android doesn't depend on glibc

(*) this is more of an issue with the linux-gnu targets which depend on glibc; there an old ubuntu image is used to keep the supported glibc version (of Rust programs produced by cross) as low as possible

@japaric japaric mentioned this pull request Dec 9, 2020
Merged
reitermarkus
reitermarkus reviewed Dec 10, 2020
View reviewed changes
@reitermarkus
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 12, 2020

Build succeeded:

@bors bors bot merged commit d84e4f4 into master Dec 12, 2020
@bors bors bot deleted the fix-ci branch December 12, 2020 04:02
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reitermarkus reitermarkus reitermarkus approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@japaric @reitermarkus @Emilgardis