Fix *-solaris targets
#1495
Merged
Fix *-solaris targets
#1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `x86_64-sun-solaris` target was deprecated in Rust 1.52.0[1] and removed in Rust 1.76.0[2], in favour of `x86_64-pc-solaris`. [1]: rust-lang/rust#82216 [2]: rust-lang/rust#118091
Adapted from rust-lang/rust#108951 and rust-lang/rust#81229.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
meh, I thought I fixed that... /ci try --target *solaris |
This comment has been minimized.
This comment has been minimized.
Try run for comment
Successful Jobs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1424.
Adapted from rust-lang/rust#108951 and rust-lang/rust#81229 (with some minor changes to satisfy ShellCheck and account for broken symlinks).
This PR also renames
x86_64-sun-solaristox86_64-pc-solaris, as the former was deprecated in Rust 1.52.0 and removed in Rust 1.76.0, making this a breaking change.