improved heuristic to find project root #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -19,6 +19,8 @@ impl LanguageServer for BaconLs { | |||
| async fn initialize(&self, params: InitializeParams) -> jsonrpc::Result<InitializeResult> { | |||
| tracing::info!("initializing {PKG_NAME} v{PKG_VERSION}",); | |||
| tracing::debug!("initializing with input parameters: {params:#?}"); | |||
| let project_root = Cargo::find_project_root(¶ms).await; | |||
There was a problem hiding this comment.
@Leandros would it not be possible to get the root directory directly from the LSP client? Because nvim-lspconfig provides a method to specify how to find the root dir. And LspInfo correctly displays this dir.
There was a problem hiding this comment.
@michaelrommel, this is exactly what I'm doing now.
We're now trying to look at a few directories, instead of just the git root. Fixes crisidev#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now trying to look at a few directories, instead of just the git root.
Fixes #49