detect rust projects that are not on git root #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine, you're having a project a few levels deep in your Git repository; the previous heuristic wouldn't be able to detect this. We know check whether a `Cargo.toml` exists on the git root before trying a few other options.
crisidev
approved these changes
Apr 26, 2025
There was a problem hiding this comment.
Nice and simple enough.. this will close #49 if I am not mistaken.
BTW something changed in terms of dependencies during the upgrade to the new tower-lsp and I am having real troubles building and releasing new versions for the vscode extensions. I'll use this change to cut a new release today and fix that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine, you're having a project a few levels deep in your Git repository; the previous heuristic wouldn't be able to detect this. We know check whether a
Cargo.tomlexists on the git root before trying a few other options.