Correctly shutdown synchronize publish task #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 51.38% 51.40% +0.01%
==========================================
Files 4 4
Lines 1045 1066 +21
Branches 1045 1066 +21
==========================================
+ Hits 537 548 +11
- Misses 473 483 +10
Partials 35 35 ☔ View full report in Codecov by Sentry. |
|
This looks good and it is a sensible way to fix the issue. I probably have some time later and will pass the cancellation token to the background bacon process as well. Please run a cargo fmt to make the CI happy and once I am back home I'll merge. |
|
I'll merge and fix the CI. |
|
I've implemented the bacon shutdown as well. It's in the second commit in the PR. ;) |
|
Yep, I noticed. Very nice! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my preliminary testing, this correctly shuts down the background task.
From looking at the shutdown function; it probably makes sense to apply the same pattern to the background task running
bacon. I did not test it withbaconrunning in the background, because I usually run it in a separate terminal window. The sameCancellationTokencould be reused.If I have some time this weekend, I'll see that I can tackle that as well.