remove polling; wait for modify events to .bacon-locations before pushing diagnostics to editor
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All further threads are unnecessary. There isn't much I/O happening in *parallel*. This reduces the startup overhead when running on machines with many cores.
Instead of constantly polling in a loop for any changes to the `.bacon-locations`, and constantly pushing updates to the editor via LSP, this will watch for changes to the `.bacon-locations` and only then reevaluate the file and push diagnostics to the editor. This uses the `notify` crate for cross-platform compatibility (it's used by rust-analyzer itself, for example). To avoid pushing too many updates at once the events are debounced using `notify-debouncer-full`. The `syncronize_all_open_files_wait_millis` configuration that was previously used as a wait time between polls is now used as a timeout, ensuring that bacon-ls receives updates at least this often. This allows us to move users silently over to the improved implementation without requiring any new configuration or re-configuration.
Closed
|
Looks good. I'll merge and will probably do some cleanup before releasing a new version. Thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of constantly polling in a loop for any changes to the
.bacon-locations, and constantly pushing updates to the editor viaLSP, this will watch for changes to the
.bacon-locationsand only thenreevaluate the file and push diagnostics to the editor. This uses the
notifycrate for cross-platform compatibility (it's used byrust-analyzer itself, for example).
To avoid pushing too many updates at once the events are debounced using
notify-debouncer-full. Thesyncronize_all_open_files_wait_millisconfiguration that was previously used as a wait time between polls is
now used as a timeout, ensuring that bacon-ls receives updates at least
this often. This allows us to move users silently over to the improved
implementation without requiring any new configuration or
re-configuration.