Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 5 files changed
- 2 contributors
Commits on Feb 27, 2025
-
constraint tokio runtime to 4 threads max
All further threads are unnecessary. There isn't much I/O happening in *parallel*. This reduces the startup overhead when running on machines with many cores.
-
remove polling; wait for modify events to diag file
Instead of constantly polling in a loop for any changes to the `.bacon-locations`, and constantly pushing updates to the editor via LSP, this will watch for changes to the `.bacon-locations` and only then reevaluate the file and push diagnostics to the editor. This uses the `notify` crate for cross-platform compatibility (it's used by rust-analyzer itself, for example). To avoid pushing too many updates at once the events are debounced using `notify-debouncer-full`. The `syncronize_all_open_files_wait_millis` configuration that was previously used as a wait time between polls is now used as a timeout, ensuring that bacon-ls receives updates at least this often. This allows us to move users silently over to the improved implementation without requiring any new configuration or re-configuration.
-
Merge pull request #34 from Leandros/dev
remove polling; wait for modify events to `.bacon-locations` before pushing diagnostics to editor
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.16.0...0.17.0