Skip to content

Support MSSQL placeholders #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

Support MSSQL placeholders #44

merged 2 commits into from
Apr 23, 2024

Conversation

tmzane
Copy link
Collaborator

@tmzane tmzane commented Apr 23, 2024

This PR adds support for MSSQL placeholders.

Based on the info from https://github.com/microsoft/go-mssqldb.

cristaloleg
cristaloleg reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I didn't know that MSSQL has their own style. Can you update GUIDE.md please? (Argument placeholder section)

@tmzane
Copy link
Collaborator Author

tmzane commented Apr 23, 2024

I didn't know that MSSQL has their own style.

I just found out myself :D

@tmzane tmzane requested a review from cristaloleg April 23, 2024 19:15
@cristaloleg cristaloleg merged commit a00936f into cristalhq:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmzane @cristaloleg