Skip to content

Make Builder more strict #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2022
Merged

Make Builder more strict #19

merged 3 commits into from
Nov 22, 2022

Conversation

cristaloleg
Copy link
Member

No description provided.

@cristaloleg cristaloleg requested a review from tmzane November 21, 2022 19:19
storozhukBM
storozhukBM approved these changes Nov 21, 2022
View reviewed changes
Copy link

@storozhukBM storozhukBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022 •
edited
Loading

Codecov Report

Base: 91.39% // Head: 91.39% // No change to project coverage 👍

Coverage data is based on head (44ced9f) compared to base (4723412).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files           1        1           
  Lines          93       93           
=======================================
  Hits           85       85           
  Misses          6        6           
  Partials        2        2
Impacted Files Coverage Δ
builq.go 91.39% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tmzane
tmzane approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@tmzane tmzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, by default ftw 😎

@cristaloleg cristaloleg changed the title Add StrictBuilder Make Builder more strict Nov 22, 2022
@cristaloleg cristaloleg merged commit 45ae46f into main Nov 22, 2022
@cristaloleg cristaloleg deleted the add-strict-builder branch November 22, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storozhukBM storozhukBM storozhukBM approved these changes

+1 more reviewer

@tmzane tmzane tmzane approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristaloleg @codecov-commenter @storozhukBM @tmzane