correct parsing values for slice of strings with commas #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristaloleg help to review the PR |
|
I think #63 should be reopened and the proper solution should be: everyone can set it's own slice separator (which should be default to |
|
thanks, i will look for solution. |
|
@cristaloleg i have changed approach. added the SliceSeparator option, which is passed to Loader so that it can use it to work with slices. all tests are passed |
sattellite
commented
May 13, 2025
|
could you please create a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slice of strings can contain strings with commas. Fixed the function for represent such slice into a string. The special unicode character is used as separator, which is described as "record separator".
Fix for #160