Skip to content

docs: fix README typo #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2022
Merged

docs: fix README typo #132

merged 1 commit into from
Oct 8, 2022

Conversation

tmzane
Copy link
Contributor

@tmzane tmzane commented Oct 7, 2022

Hi there 👋

Great library, I like you style! I've written a similar one (although it's limited to environment variables), maybe we could share some inspiration.

Would you like some assistance with any of the open issues? I'd be happy to help!

cristaloleg
cristaloleg previously approved these changes Oct 7, 2022
@cristaloleg
Copy link
Member

Thank you for kind words. Yeah, I have something to fix, will try to share as much info as possible this weekend so maybe you will pick up something.

@cristaloleg
Copy link
Member

Will fix docs in 1hr and update your MR, feel free to leave it for now 😉

@cristaloleg
Copy link
Member

Ah, rebasing via Github UI drops GPG sign, can you manually rebase on the latest main, please?

@tmzane
Copy link
Contributor Author

tmzane commented Oct 7, 2022

Sure, will do

@tmzane
Copy link
Contributor Author

tmzane commented Oct 7, 2022

Looks like there is a problem with commit signing on my side, I'll take a look and come back

@tmzane
Copy link
Contributor Author

tmzane commented Oct 7, 2022

Fixed 🎉
Turns out, ssh-agent lost my key for some reason 😅

@cristaloleg cristaloleg merged commit 6eccaaa into cristalhq:main Oct 8, 2022
@tmzane tmzane deleted the fix-readme-typo branch October 8, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants