Skip to content

[WIP] [release-1.30] Enable composefs support in CRI-O #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[WIP] [release-1.30] Enable composefs support in CRI-O #8619

wants to merge 11 commits into from

Conversation

kwilczynski
Copy link
Contributor

@kwilczynski kwilczynski commented Sep 18, 2024 •
edited
Loading

What type of PR is this?

/kind dependency-change
/kind feature
/kind other

What this PR does / why we need it:

Warning

This is an experiment. Please keep this in mind when offering reviews.

TBA

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 18, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@openshift-ci openshift-ci bot added the kind/other Categorizes issue or PR as not clearly related to any existing kind/* category label Sep 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:
  • OWNERS [kwilczynski]

    Need more approvers for rest parts.

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski kwilczynski self-assigned this Sep 18, 2024
@kwilczynski kwilczynski changed the title Update dependencies required to enable composefs support [WIP] [release-1.30] Enable composefs support in CRI-O Sep 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@kwilczynski kwilczynski force-pushed the feature/backport-composefs-to-release-1.30 branch from c651bcb to 6cda375 Compare September 18, 2024 20:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@kwilczynski kwilczynski force-pushed the feature/backport-composefs-to-release-1.30 branch 10 times, most recently from 0502a69 to 5bce93c Compare September 24, 2024 08:34
@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@kwilczynski kwilczynski force-pushed the feature/backport-composefs-to-release-1.30 branch 2 times, most recently from 5dfcb22 to 91ba0f2 Compare September 24, 2024 08:53
@kwilczynski
Copy link
Contributor Author

/retest

3 similar comments
@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski kwilczynski force-pushed the feature/backport-composefs-to-release-1.30 branch 7 times, most recently from bd26074 to 931993e Compare October 17, 2024 15:13
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
Krzysztof Wilczyński added 10 commits October 21, 2024 17:51
Update dependencies required to enable composefs support
f125993 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Update signature of storage.DefaultStoreOptions() to reflect API changes
8bef410 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Use function netlink.ConntrackDeleteFilters() to reflect API changes
cce13dc 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Replace old package with github.com/moby/sys/user as the new dependency
0aa8be5 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Suppress linter warnings for deprecated API without a feasible replac…
99f83ff 
…ement

Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Update unshare syscall index number following seccomp package update
8730cf5 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Update tests mocks to reflect dependencies updates
7e37e30 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Move Nix derivation to use buildGoModule function and pin Go to 1.22.7
28216e7 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Update Packit build configuration
a98ec33 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Bump hardcoded image pull timeout to 5 minutes
c6e385c 
See: https://github.com/containers/image/issues/2585

Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/backport-composefs-to-release-1.30 branch from 931993e to d373b38 Compare October 21, 2024 08:53
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
Pin mattn/go-sqlite3 package to release before 2.x
af2a1b2 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/backport-composefs-to-release-1.30 branch from d373b38 to af2a1b2 Compare October 21, 2024 09:03
@kwilczynski
Copy link
Contributor Author

Closing for now. Will re-open in the future, if needed.

@kwilczynski kwilczynski deleted the feature/backport-composefs-to-release-1.30 branch October 30, 2024 09:35
@kwilczynski kwilczynski mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

1 more reviewer

@mtrmac mtrmac mtrmac left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@kwilczynski kwilczynski

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/feature Categorizes issue or PR as related to a new feature. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kwilczynski @littlejawa @mtrmac @openshift-merge-robot