Skip to content

[release-1.28] OCPBUGS-42912: Cherry-pick changes from containers/storage/pull#2134 #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

[release-1.28] OCPBUGS-42912: Cherry-pick changes from containers/storage/pull#2134 #8677

merged 1 commit into from
Oct 21, 2024

Conversation

kwilczynski
Copy link
Contributor

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from https://github.com/containers/storage/pull#2134 as these changes contain a fix that needs to be backported to CRI-O release 1.28, part of OpenShift 4.15 release.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@kwilczynski kwilczynski requested a review from mrunalp as a code owner October 15, 2024 09:25
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Oct 15, 2024
@kwilczynski kwilczynski changed the title Cherry-pick changes from containers/storage/pull#2134 [release-1.28] Cherry-pick changes from containers/storage/pull#2134 Oct 15, 2024
@kwilczynski kwilczynski changed the title [release-1.28] Cherry-pick changes from containers/storage/pull#2134 [WIP] [release-1.28] Cherry-pick changes from containers/storage/pull#2134 Oct 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024
@kwilczynski
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski
Once this PR has been reviewed and has the lgtm label, please assign kolyshkin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski kwilczynski changed the title [WIP] [release-1.28] Cherry-pick changes from containers/storage/pull#2134 [WIP] [release-1.28] OCPBUGS-42912: Cherry-pick changes from containers/storage/pull#2134 Oct 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 15, 2024
@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-42912, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42912 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from https://github.com/containers/storage/pull#2134 as these changes contain a fix that needs to be backported to CRI-O release 1.28, part of OpenShift 4.15 release.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski force-pushed the feature/containers-storage-2134-to-release-1.28 branch 2 times, most recently from 0e2f678 to b805355 Compare October 16, 2024 15:22
kwilczynski
kwilczynski commented Oct 16, 2024
View reviewed changes
@kwilczynski
Copy link
Contributor Author

/retest

2 similar comments
@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

Cherry-pick changes from containers/storage/pull#2134
90361d3 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/containers-storage-2134-to-release-1.28 branch from b805355 to 90361d3 Compare October 17, 2024 10:27
@kwilczynski kwilczynski changed the title [WIP] [release-1.28] OCPBUGS-42912: Cherry-pick changes from containers/storage/pull#2134 [release-1.28] OCPBUGS-42912: Cherry-pick changes from containers/storage/pull#2134 Oct 17, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@kwilczynski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-42912, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42912 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Contributor Author

/retest

1 similar comment
@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 20, 2024

@kwilczynski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 90361d3 link true /test e2e-gcp
ci/prow/e2e-agnostic 90361d3 link true /test e2e-agnostic
ci/prow/images 90361d3 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kwilczynski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-42912, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42912 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Contributor Author

@cri-o/cri-o-maintainers, please have a look. Thank you!

@haircommander haircommander merged commit 35a2431 into cri-o:release-1.28 Oct 21, 2024
36 of 42 checks passed
@openshift-ci-robot
Copy link

@kwilczynski: Jira Issue OCPBUGS-42912: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42912 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from https://github.com/containers/storage/pull#2134 as these changes contain a fix that needs to be backported to CRI-O release 1.28, part of OpenShift 4.15 release.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski deleted the feature/containers-storage-2134-to-release-1.28 branch October 27, 2024 04:14
@kwilczynski kwilczynski mentioned this pull request Jan 1, 2025
Merged
@kwilczynski kwilczynski mentioned this pull request Jan 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

+3 more reviewers

@cyphar cyphar cyphar left review comments

@mheon mheon mheon left review comments

@Luap99 Luap99 Luap99 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@kwilczynski kwilczynski

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kwilczynski @openshift-ci-robot @giuseppe @cyphar @mheon @Luap99 @haircommander