Skip to content

Remove device mapper storage driver support #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove device mapper storage driver support #7003

wants to merge 3 commits into from

Conversation

kolyshkin
Copy link
Collaborator

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Device mapper storage driver is hard to set up, slow, and obsoleted by overlayfs.
My best guess is nobody is using it nowadays.

Let's remove it.

Which issue(s) this PR fixes:

Fixes: #7002

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove device mapper storage driver.

kolyshkin added 3 commits May 31, 2023 14:35
@kolyshkin
Makefile: rm i386 hack
54eefba 
This was needed for build-386 job in .github/workflows/test.yml, but
it is apparently no longer necessary since commit 13d7b97 added
git to the list of preinstalled packages.

This commit reverts 13d7b97.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Makefile: rm $(PROJECT) use from paths
a1076ae 
We can use relative paths now.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Remove device mapper support
b3157b0 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin requested a review from mrunalp as a code owner May 31, 2023 22:47
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 31, 2023
@openshift-ci openshift-ci bot requested review from klihub and sohankunkerkar May 31, 2023 22:48
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/deprecation labels May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@kolyshkin kolyshkin mentioned this pull request May 31, 2023
Merged
@kolyshkin
Copy link
Collaborator Author

OK, this is blocked by buildah which can't be built without libdevmapper.

Moving to draft until we have buildah release with containers/buildah#4832 included

@kolyshkin kolyshkin marked this pull request as draft May 31, 2023 23:38
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@kolyshkin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-fedora-kata b3157b0 link true /test ci-fedora-kata

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fidencio
Copy link
Contributor

@kolyshkin, devmapper can be used with Kata Containers and in the Confidential Containers front it'll be heavily used.

We're using devmapper as TEE capable kernels do not support virtio-fs, virtio-9p is not supported by several distros (and also by several hypervisors), leaving us with the only option to use devmapper as the way to share the container rootfs between host and guest via a block device.

I know, Red Hat OpenShift is not using it, AFAIU, but other users of CRi-O could.

This is not a show stopper for this PR, but I'd love to have it taken into consideration.

/cc @littlejawa @bpradipt

@openshift-ci openshift-ci bot requested a review from littlejawa July 18, 2023 12:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@fidencio: GitHub didn't allow me to request PR reviews from the following users: bpradipt.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@kolyshkin, devmapper can be used with Kata Containers and in the Confidential Containers front it'll be heavily used.

We're using devmapper as TEE capable kernels do not support virtio-fs, virtio-9p is not supported by several distros (and also by several hypervisors), leaving us with the only option to use devmapper as the way to share the container rootfs between host and guest via a block device.

I know, Red Hat OpenShift is not using it, AFAIU, but other users of CRi-O could.

This is not a show stopper for this PR, but I'd love to have it taken into consideration.

/cc @littlejawa @bpradipt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2023
@sohankunkerkar sohankunkerkar removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2023
@sohankunkerkar
Copy link
Member

Moving to draft until we have buildah release with containers/buildah#4832 included

This fix has been included in https://github.com/containers/buildah/releases/tag/v1.31.0

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2023
@github-actions GitHub Actions
Copy link

Closing this PR since it had no activity in the past 90 days.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 17, 2023
@github-actions github-actions bot closed this Dec 17, 2023
@kolyshkin kolyshkin mentioned this pull request Apr 15, 2024
Merged
@kolyshkin
Copy link
Collaborator Author

Resurrected as #8019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

@rphillips rphillips Awaiting requested review from rphillips

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate and remove device mapper storage driver
4 participants
@kolyshkin @openshift-merge-robot @fidencio @sohankunkerkar