-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.18] sandbox iface: don't fail if uid is not specified #3788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.18] sandbox iface: don't fail if uid is not specified #3788
Conversation
It is not strictly needed, just a namespace is Signed-off-by: Peter Hunt <pehunt@redhat.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #3788 +/- ##
================================================
- Coverage 40.51% 40.50% -0.02%
================================================
Files 105 105
Lines 8611 8609 -2
================================================
- Hits 3489 3487 -2
Misses 4811 4811
Partials 311 311 |
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
tests won't pass, needs a rebase. I'll do this manually |
This is an automated cherry-pick of #3774
/assign haircommander