Skip to content

cri-tools (critest) case "runtime should output OOMKilled reason" flakes when being fixed #8411

@saschagrunert

Description

@saschagrunert

Right now, the exit code and reason is not checked correctly in cri-tools: https://github.com/kubernetes-sigs/cri-tools/blob/71d27b1f93a87ff9462479a4c5f3fc8572d4715a/pkg/validate/container_linux.go#L161-L165

Expect(state.ExitCode, int32(137))

should be

Expect(state.ExitCode).To(Equal(int32(137)))

This shadows the actual test result. We should check with the following combinations if everything works as expected:

  • runc and conmon
  • runc and conmon-rs
  • crun and conmon
  • crun and conmon-rs

Reason for this issue is that I fixed this behavior in kubernetes-sigs/cri-tools#1496 which introduced failing CI tests within this repository.

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions