Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: creack/pty
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.19
Choose a base ref
...
head repository: creack/pty
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.20
Choose a head ref
  • 7 commits
  • 14 files changed
  • 2 contributors

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    5c3f42a View commit details
    Browse the repository at this point in the history
  2. Do not set file descriptor into blocking mode

    (*os.File).Fd() implicitly sets file descriptor into blocking mode [1], [2]
    We avoid that by calling (*os.File).SyscallConn instead.
    This method was added in go1.12 (released on 2019-02-25)
    
    [1]: https://pkg.go.dev/os#File.Fd
    [2]: https://cs.opensource.google/go/go/+/refs/tags/go1.20.3:src/os/file_unix.go;l=80-87
    sio committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2916954 View commit details
    Browse the repository at this point in the history
  3. Rename ioctl.go back

    This filename trick forces git to render previous commit diff
    in a more comprehensible form
    sio committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    87d82d3 View commit details
    Browse the repository at this point in the history
  4. Restore support for older Go versions

    When compiled with go older than 1.12 creack/pty will not include a fix
    for blocking Read() and will be prone to data races - but at least it will work
    
    For more information see issues: #88 #114 #156 #162
    sio committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    418593d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    75e52f1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3abf458 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge pull request #167 from sio/ioctl

    Avoid calls to (*os.File).Fd() and operations on raw file descriptor ints
    creack authored Oct 28, 2023
    Configuration menu
    Copy the full SHA
    1985fd4 View commit details
    Browse the repository at this point in the history
Loading