Sanitize the color field to allow using hex codes #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Feb 6, 2024
crazy-max
requested changes
Feb 6, 2024
There was a problem hiding this comment.
Looks good but can you:
- squash your commits
- run
docker buildx bake pre-checkinper https://github.com/crazy-max/ghaction-github-labeler/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request - push commit with generated files changes similar to https://github.com/crazy-max/ghaction-github-labeler/pull/187/commits with commit message
update generated content
Thanks!
Sorry, I've read the contributing instructions but I didn't get that you meant the result of running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found myself struggling with the color field, as I was unfamiliar with the underlying GitHub API.
This PR fixes #153 and adds a test scenario for hex code colors.
Replaces and closes #172.