Fixes an issue that caused focus trap to not work when clicking inside the Image Editor on element pages #17455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the
activate
listener on the<body>
element causedtabindex="0"
to be set on the body element. After opening the Image Editor modal, clicking anywhere inside would set focus on the body — not inside the current layer — since the body itself was focusable.This PR checks to make sure it doesn't set
tabindex="0"
on the body element to prevent focus from being dropped into the wrong layer.Related issues