add debounce to SearchBar #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this be an issue for modules that use APIs with rate limits? |
|
The search api will only be called 0.25 seconds after the user stops typing, any sooner and the timer is reset. The api call rate would be at most 4 requests per second which is within the threshold for most services. If that delay is too low I can change it to 0.3/4 seconds. |
|
yeah maybe make it a 0.5s since that the delay change wouldn't be that visible for the user |
|
I've changed the delay to 0.5s |
cranci1
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds debounced search for titles so results appear without needing to press enter.