Skip to content

New Analytics feature #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2025
Merged

New Analytics feature #27

merged 5 commits into from
Mar 3, 2025

Conversation

hamzenis
Copy link
Contributor

@hamzenis hamzenis commented Mar 2, 2025

Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
@cranci1
Copy link
Owner

cranci1 commented Mar 2, 2025

So, this is collect data about the app right, i don't really think i'll add data collection to Sora. Mainly for three reasons:

  • First: I want to make this app long lived, user data even if small is something that apps shouldn't collect, at least for my morality of FOSS apps.

  • Secondly: I don't want people to complain about having their data even if it can be toggled off, since they are just gonna complain about it being in the app.

  • Lastly: The data are public, so anyone can access the url, by just check the src/URL Reqeuests, which is not the best since it will need to manage user data even if anonymously.

But I'll still like to know why you do thing it is a good idea, because yes it is, but people will complain a lot 100%. Other than that good job, and thanks for the help you are giving me.

hamzenis and others added 2 commits March 2, 2025 19:57
	modified:   Sora.xcodeproj/project.pbxproj
	renamed:    Sora/Utils/Analytics/UIDevice+Model.swift -> Sora/Utils/Extensions/UIDevice+Model.swift
@cranci1 cranci1 merged commit a3f319d into cranci1:main Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants