Skip to content

Conversation

aaronliu0130
Copy link
Member

@aaronliu0130 aaronliu0130 commented Mar 10, 2025

Bump the date again before releasing 2.0.1, then squash and merge and release (remember to create a new tag and follow the testing process in CONTRIBUTING.rst).

@aaronliu0130 aaronliu0130 requested review from jayvdb and cclauss March 10, 2025 03:00
@aaronliu0130 aaronliu0130 changed the title bump 2.0.1 release date again chore: bump 2.0.1 release date again Mar 10, 2025
cclauss
cclauss previously approved these changes Mar 10, 2025
@aaronliu0130
Copy link
Member Author

@jayvdb Now that #317 has been merged, could you bump the release date here if needed and then release 2.0.1? Thanks!

@cclauss cclauss self-requested a review March 17, 2025 13:59
@cclauss cclauss dismissed their stale review March 17, 2025 14:01

Blocked by

@aaronliu0130 aaronliu0130 requested review from cclauss and removed request for cclauss March 19, 2025 15:50
@cclauss cclauss merged commit b8d33cf into develop Apr 2, 2025
15 checks passed
@cclauss cclauss deleted the bump branch April 2, 2025 12:20
@cclauss
Copy link
Member

cclauss commented Apr 2, 2025

@@ -3,7 +3,7 @@ on:
pull_request:
paths-ignore: "*.rst"
push:
paths-ignore: "*.rst"
# paths-ignore: "*.rst"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why lol *.rst changes cannot break code/tests and pre-commit errors are in a separate workflow anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three required GitHub Actions tests before a pull request is merged. Without this change, a pull request that only changes .rst files can never be merged. Failing to plan is planing to fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Your change does not do anything to stop that, though, as all you changed is the part applying to pushes to the master and develop branches. I'm currently asking https://github.com/orgs/community/discussions/155654 to implement an alternative measure of path-filtering (removing the ignorance from both is also an option but I don't think we need it enough for a separate commit; I won't oppose such a change though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants