-
Notifications
You must be signed in to change notification settings - Fork 294
chore: bump 2.0.1 release date again #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
v2.0.1 published...https://github.com/cpplint/cpplint/releases |
@@ -3,7 +3,7 @@ on: | |||
pull_request: | |||
paths-ignore: "*.rst" | |||
push: | |||
paths-ignore: "*.rst" | |||
# paths-ignore: "*.rst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why lol *.rst changes cannot break code/tests and pre-commit errors are in a separate workflow anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three required GitHub Actions tests before a pull request is merged. Without this change, a pull request that only changes .rst files can never be merged. Failing to plan is planing to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Your change does not do anything to stop that, though, as all you changed is the part applying to pushes to the master and develop branches. I'm currently asking https://github.com/orgs/community/discussions/155654 to implement an alternative measure of path-filtering (removing the ignorance from both is also an option but I don't think we need it enough for a separate commit; I won't oppose such a change though).
Bump the date again before releasing 2.0.1, then squash and merge and release (remember to create a new tag and follow the testing process in CONTRIBUTING.rst).