Drop Python 3.8 #334
Drop Python 3.8 #334
Conversation
|
Does not compute. Pylint 3.3.5 is available for PyPy 3.11 on Linux and macOS but not Windows‽ |
Yes, unfortunately correct... pylint-dev/pylint#10286 (review) |
|
Pylint successfully installs and runs with PyPy3.11 on my Windows VM, but not on GitHub's apparently. |
|
We could ignore the pypy3.11 issue for a while until release where maybe we can decide to just yank the pypy3.11 tests. Either way, this should be the next PR merged before any changelog-worthy changes so we have updated changelog and version entries. |
Also, remove ruff target-version property as it detects the target version from requires-python by default.
pyproject.toml
Outdated
| @@ -43,7 +42,7 @@ dependencies = [ ] | |||
| optional-dependencies.dev = [ | |||
| "mypy", | |||
| "parameterized", | |||
| "pylint>=2.11", | |||
| "pylint==3.3.5", | |||
There was a problem hiding this comment.
| "pylint==3.3.5", | |
| "pylint>=3.3.4", |
There was a problem hiding this comment.
I am surprised that this works since the dedeprecation only happens in pylint 3.3.5 and the pypy3.11 logs indicate that it installs 3.3.4.
|
What is release vNEXT? Is it v2.0.2, v2.1.0, or v3.0.0? Different pull requests making different guesses is suboptimal (git conflicts). It is best to make the vNEXT version number decision at release time. v2.0.1 is preserved at: |
|
Thanks for the review! I would appreciate it if I or someone else had the chance to review your changes before they are unilaterally merged, though. (Not that that means a PR should be stuck just because the author didn't reply to changes; 24 hours should be enough.) |
Pylint released their update on dedeprecating the getopt and optparse modules.Should merge this after we release 2.0.1.