Skip to content

Add ruff format to pre-commit #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

Add ruff format to pre-commit #333

merged 2 commits into from
Mar 12, 2025

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 9, 2025 •
edited
Loading

@cclauss cclauss force-pushed the ruff-format branch 2 times, most recently from cd6eb3e to b602413 Compare March 9, 2025 16:10
@cclauss cclauss mentioned this pull request Mar 9, 2025
Merged
aaronliu0130
aaronliu0130 requested changes Mar 9, 2025
View reviewed changes
Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you split the formatting of the .py files into a separate commit so that we can add that one to git blame ignore-revs, though? Thanks!

@cclauss cclauss force-pushed the ruff-format branch 4 times, most recently from 380cb13 to 0ccfcbe Compare March 12, 2025 08:39
@cclauss
Copy link
Member Author

cclauss commented Mar 12, 2025

@aaronliu0130 The first commit is only Python files. The second commit is only non-Python files.

@cclauss cclauss requested review from aaronliu0130 and jayvdb March 12, 2025 09:00
@cclauss
Copy link
Member Author

cclauss commented Mar 12, 2025

Reviews please.

@aaronliu0130 aaronliu0130 merged commit ac52a79 into develop Mar 12, 2025
10 checks passed
@cclauss cclauss deleted the ruff-format branch March 12, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronliu0130 aaronliu0130 aaronliu0130 approved these changes

@jayvdb jayvdb Awaiting requested review from jayvdb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @aaronliu0130