Skip to content

Fix missing comma between items in _CPP_HEADERS #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Hs293Go
Copy link
Contributor

@Hs293Go Hs293Go commented Dec 2, 2024

This PR restores a comma between 'latch' and 'numbers'. Currently, the missing comma causes them to be implicitly concatenated into 'latchnumbers', so cpplint won't recognize either header in C++20 code and report a bogus build/include_order error.

Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we really should've noticed this before the release.

@aaronliu0130 aaronliu0130 merged commit 14445f3 into cpplint:develop Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants