CONTRIBUTING.rst: Default branch is develop, add pre-commit #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronliu0130
approved these changes
Mar 21, 2025
| @@ -66,9 +71,9 @@ You can test your changes under your local python environment by running the tes | |||
| pytest | |||
| # lint the code | |||
| pylint cpplint.py | |||
| flake8 | |||
| pre-commit run --all-files | |||
There was a problem hiding this comment.
If the previous changes passed pre-commit, then newer ones should also pass, no?
There was a problem hiding this comment.
You can run this command at any time when you are working on modifications to see how the spell checker and linters will respond to your changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.