Skip to content

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 18, 2025

@cclauss cclauss force-pushed the mypy branch 5 times, most recently from 708f5a6 to 5d23163 Compare March 18, 2025 18:40
@aaronliu0130
Copy link
Member

No problem merging as-is. I wonder what’s our standard for what to put in pre-commit vs tox, though. Like ruff format is obviously pre-commit but pylint, flake8, and ruff check not so much.

@cclauss
Copy link
Member Author

cclauss commented Mar 18, 2025

pre-commit is for really fast (subsecond?) stuff and tox is for slower stuff. This aligns with pre-commit's recommendations.

For runtimes, try: pre-commit run --all-files --verbose

I think we can lose flake8 at this point.

@aaronliu0130 aaronliu0130 merged commit d0456bd into develop Mar 18, 2025
10 checks passed
@cclauss cclauss deleted the mypy branch March 18, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants