Skip to content

Conversation

tkruse
Copy link
Contributor

@tkruse tkruse commented Aug 2, 2024

No description provided.

@tkruse tkruse requested a review from aaronliu0130 August 2, 2024 14:19
@aaronliu0130
Copy link
Member

aaronliu0130 commented Aug 2, 2024

(continuing discussion from that PR)

Still tox.ini still references py3.7. Seems CI does not use tox.ini environment list, which is confusing

I found the entire gh-actions part of tox.ini to be confusing. It looks like the colons on the left are some environmental variable set by CI and the thing on the right tells tox what interpreter that envar maps to.

The "envlist" at the top is all the versions tox will iterate through by default. The CI only installs one version of Python on each machine, so yeah. It does seem pretty reasonable to stop testing it by default, though.

@aaronliu0130 aaronliu0130 merged commit 3d9c9d0 into develop Aug 15, 2024
6 checks passed
@aaronliu0130 aaronliu0130 deleted the fixpy3.8 branch August 15, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants