Update SeaweedFS to v3.97 to enable SSE support #1373
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WalkthroughHelm chart for SeaweedFS is updated: Chart.yaml bumps appVersion from 3.96 to 3.97 and chart version from 4.0.396 to 4.0.397. values.yaml changes the volume resizeHook.image from bitnami/kubectl to alpine/k8s:1.28.4. No other files or fields are modified. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as Helm User
participant H as Helm (SeaweedFS Chart)
participant K as Kubernetes API
participant RH as Resize Hook (alpine/k8s:1.28.4)
participant PVC as PersistentVolumeClaim
U->>H: helm upgrade --install (chart v4.0.397, app 3.97)
H->>K: Apply/Update resources
alt dataDirs type is persistentVolumeClaim and size changed
K-->>RH: Create/Run resize hook job (alpine/k8s:1.28.4)
RH->>PVC: Patch/resize PVC and related resources
RH-->>K: Job completes
else no PVC resize needed
K-->>H: No hook execution
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello @kvaps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on upgrading the SeaweedFS application version within its Helm chart to leverage new features like SSE support. It also updates a dependency image used for volume resizing within the chart, ensuring the deployment remains current and efficient.
Highlights
- SeaweedFS Version Update: The SeaweedFS application version has been updated from "3.96" to "3.97". This update is intended to enable Server-Sent Events (SSE) support as indicated in the pull request title.
- Helm Chart Version Update: The Helm chart version for SeaweedFS has been incremented from "4.0.396" to "4.0.397" to align with the new application version.
- Resize Hook Image Change: The image used for the volume resize hook in the Helm chart's values has been changed from "bitnami/kubectl" to "alpine/k8s:1.28.4". This likely improves compatibility or optimizes the image for the resize operation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates SeaweedFS to version 3.97. The changes include updating the appVersion and chart version in Chart.yaml, which is done correctly. The change in values.yaml from bitnami/kubectl to alpine/k8s:1.28.4 for the resizeHook is a positive one, as it uses a version-pinned and likely more lightweight image. The changes are straightforward and look good.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/system/seaweedfs/charts/seaweedfs/Chart.yaml (1)
4-6: Add a release-note entry advertising SSE availability.The PR’s release-note is empty. Please add a short note (e.g., “Update SeaweedFS to v3.97 to enable S3 SSE support”) to surface this change to users.
packages/system/seaweedfs/charts/seaweedfs/values.yaml (1)
359-362: Prefer official kubectl image and version-skew alignment.Optional: use the official image and match the tag to your supported K8s minor to avoid client/server skew; pin by digest if possible.
Apply if you agree:
- image: alpine/k8s:1.28.4 + image: registry.k8s.io/kubectl:v1.28.4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
packages/system/seaweedfs/charts/seaweedfs/Chart.yaml(1 hunks)packages/system/seaweedfs/charts/seaweedfs/values.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (2)
packages/system/seaweedfs/charts/seaweedfs/Chart.yaml (1)
4-6: Version bump to SeaweedFS 3.97 and chart 4.0.397 — LGTM.Matches the PR goal to enable SSE via the upstream release.
packages/system/seaweedfs/charts/seaweedfs/values.yaml (1)
359-362: resizeHook job uses sh and kubectl; confirm image contents
The hook template invokes commands viash -xec(no bash-specific syntax) and runskubectl delete/kubectl patch. Ensure thealpine/k8s:1.28.4image actually includes thekubectlbinary in its PATH and is published for all architectures your clusters require.
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does
Release note
Summary by CodeRabbit