[ci] Stop using personal domain for CI #1322
Conversation
Migrate away from using a private domain for build infra. Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
WalkthroughThe update modifies the Talos cluster configuration patch in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (8)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello @lllamnyp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the CI build infrastructure to stop using a personal domain. This change migrates all references from lllamnyp.su to aenix.org within the configuration for image registry mirrors, ensuring that our build processes are more robust and independent of personal resources.
Highlights
- CI Infrastructure Update: The pull request updates the domain used for various image registry mirrors within the
hack/e2e-prepare-cluster.batsscript, replacinglllamnyp.suwithaenix.org. This change ensures that the CI build infrastructure no longer relies on a personal domain.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the CI configuration from a personal domain to a new one, which aligns with the stated goal. The changes are straightforward and correct. I have included one review comment with a suggestion to improve the maintainability of the mirror configuration by using a shell variable for the common domain name. This will make any future updates to the domain easier to manage.
| - https://dockerio.nexus.aenix.org | ||
| cr.fluentbit.io: | ||
| endpoints: | ||
| - https://fluentbit.nexus.lllamnyp.su | ||
| - https://fluentbit.nexus.aenix.org | ||
| docker-registry3.mariadb.com: | ||
| endpoints: | ||
| - https://mariadb.nexus.lllamnyp.su | ||
| - https://mariadb.nexus.aenix.org | ||
| gcr.io: | ||
| endpoints: | ||
| - https://gcr.nexus.lllamnyp.su | ||
| - https://gcr.nexus.aenix.org | ||
| ghcr.io: | ||
| endpoints: | ||
| - https://ghcr.nexus.lllamnyp.su | ||
| - https://ghcr.nexus.aenix.org | ||
| quay.io: | ||
| endpoints: | ||
| - https://quay.nexus.lllamnyp.su | ||
| - https://quay.nexus.aenix.org | ||
| registry.k8s.io: | ||
| endpoints: | ||
| - https://k8s.nexus.lllamnyp.su | ||
| - https://k8s.nexus.aenix.org |
There was a problem hiding this comment.
For better maintainability, consider extracting the repeated domain nexus.aenix.org into a shell variable. This will make future updates easier and less error-prone by avoiding repetition.
You can achieve this with the following steps:
- Define a variable before this
heredocblock, for example:local NEXUS_DOMAIN="nexus.aenix.org". - Update the
heredocstart on line 119 from<<'EOF'to<<EOFto allow variable expansion. - Replace the hardcoded domain in the mirror URLs with the variable, for example:
- https://dockerio.${NEXUS_DOMAIN}.
This change would apply to all the updated mirror URLs in this block (lines 139-157).
Migrate away from using a private domain for build infra.
What this PR does
Release note
Summary by CodeRabbit