Skip to content

[cozystack-api] Fix resourceVersion error #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

[cozystack-api] Fix resourceVersion error #1170

merged 1 commit into from
Jul 9, 2025

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Jul 8, 2025 •
edited
Loading

Signed-off-by: Andrei Kvapil kvapss@gmail.com

What this PR does

This PR fixes error:

failed to update HelmRelease: helmreleases.helm.toolkit.fluxcd.io "xxx" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update

Release note

[cozystack-api] Fix resourceVersion error

@kvaps
[cozystack-api] Fix resourceVersion error
e6ffb4f 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps requested review from lllamnyp and klinch0 as code owners July 8, 2025 16:45
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025 •
edited
Loading

Walkthrough

The update logic in the REST struct for applications now ensures that the ResourceVersion is set before performing an update. If missing, it retrieves the current resource from Kubernetes to obtain and set the correct ResourceVersion, supporting proper optimistic concurrency control.

Changes

File(s) Change Summary
pkg/registry/apps/application/rest.go Added logic to ensure ResourceVersion is set before update; fetches from Kubernetes if absent.

Suggested labels

bug, size:XS

Poem

A hop and a skip, a version to find,
When ResourceVersion is left behind.
Now we fetch and set with care,
So updates land without a scare.
Concurrency safe, the code is neat—
Bugs retreat in swift defeat!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 699d38d and e6ffb4f.

📒 Files selected for processing (1)
  • pkg/registry/apps/application/rest.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: pre-commit
  • GitHub Check: Build
🔇 Additional comments (1)
pkg/registry/apps/application/rest.go (1)

426-434: LGTM - Proper fix for resourceVersion error with optimistic concurrency control.

The implementation correctly handles the missing ResourceVersion by fetching the current resource state. This follows Kubernetes best practices for optimistic concurrency control and should resolve the resourceVersion error mentioned in the PR objectives.

The code properly:

  • Checks if ResourceVersion is missing before making the additional GET request
  • Uses appropriate error handling with wrapped errors
  • Maintains consistency with the existing codebase patterns
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps kvaps merged commit fe1776b into main Jul 9, 2025
18 checks passed
@kvaps kvaps deleted the fix-resourceversion branch July 9, 2025 08:20
This was referenced Aug 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klinch0 klinch0 klinch0 approved these changes

@lllamnyp lllamnyp Awaiting requested review from lllamnyp lllamnyp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvaps @klinch0