Skip to content

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Apr 25, 2025

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

  • Chores
    • Updated version constraints for multiple HelmRelease resources to use an explicit semantic version range (>= 0.0.0-0) instead of a wildcard or unspecified value, clarifying eligible chart versions for deployment.
    • Renamed and updated version variable in build scripts to improve version tagging and packaging consistency.
    • Enhanced deployment verification by adding readiness checks for HelmReleases, with failure detection and reporting for non-ready releases.

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps requested review from lllamnyp and klinch0 as code owners April 25, 2025 10:08
Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

Walkthrough

This change updates multiple HelmRelease manifests across various application and infrastructure components. The primary modification is the introduction or adjustment of the version field under the sourceRef or chart.spec sections, setting the version constraint for Helm chart sources to '>= 0.0.0-0'. Previously, some manifests used a wildcard ('*') or had no explicit version constraint. Additionally, the Makefile and environment scripts rename the version variable from VERSION to COZYSTACK_VERSION and change its assignment command. The hack/e2e.sh script was enhanced to wait for all HelmReleases to be ready and fail early if any are not. No changes were made to exported entities or control flow beyond these.

Changes

Files (grouped) Change Summary
packages/apps/bucket/templates/helmrelease.yaml
packages/apps/nats/templates/nats.yaml
packages/extra/ingress/templates/nginx-ingress.yaml
packages/extra/seaweedfs/templates/seaweedfs.yaml
Changed Helm chart version constraint from wildcard '*' to explicit semver range '>= 0.0.0-0'.
packages/apps/kubernetes/templates/helmreleases/cert-manager-crds.yaml
.../cert-manager.yaml
.../cilium.yaml
.../csi.yaml
.../fluxcd.yaml
.../gpu-operator.yaml
.../ingress-nginx.yaml
.../monitoring-agents.yaml
.../vertical-pod-autoscaler-crds.yaml
.../vertical-pod-autoscaler.yaml
.../victoria-metrics-operator.yaml
Added version: '>= 0.0.0-0' field to HelmRelease manifests under sourceRef or chart.spec to specify version constraint.
packages/core/platform/templates/helmreleases.yaml Added version: '>= 0.0.0-0' under chart.spec.sourceRef in HelmRelease resource.
packages/system/Makefile
scripts/common-envs.mk
Renamed variable VERSION to COZYSTACK_VERSION and changed its assignment command from git describe --tags --abbrev=0 to git describe --tags. Updated Makefile target to use COZYSTACK_VERSION.
hack/e2e.sh Added logic to wait for all HelmReleases to reach ready condition with timeout, and fail early if any are not ready.

Sequence Diagram(s)

sequenceDiagram
    participant Script as hack/e2e.sh
    participant Kubernetes as K8s API Server
    participant HelmRelease as HelmRelease Resources

    Script->>Kubernetes: kubectl wait for all HelmReleases ready (parallel)
    Kubernetes-->>Script: HelmRelease readiness status
    alt Any HelmRelease not ready
        Script->>Script: Print failed HelmReleases
        Script->>Script: Exit with failure
    else All HelmReleases ready
        Script->>Script: Continue execution
    end
Loading
sequenceDiagram
    participant User
    participant HelmRelease
    participant HelmRepository

    User->>HelmRelease: Apply manifest with version constraint
    HelmRelease->>HelmRepository: Resolve chart version (>= 0.0.0-0)
    HelmRepository-->>HelmRelease: Provide matching chart version(s)
    HelmRelease-->>User: Deploy chart using resolved version
Loading

Possibly related PRs

Suggested labels

ok-to-test

Suggested reviewers

  • klinch0
  • lllamnyp

Poem

In the meadow of YAML, a version appears,
No more wildcards, the intent now clear.
With >= 0.0.0-0, the charts align,
Rabbits hop forward, all deployments just fine.
Helm charts in order, releases anew—
A hop, a skip, and a version for you!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kvaps added 2 commits April 25, 2025 12:13
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Copy link
Member

@lllamnyp lllamnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79b5c6b and 69b3ddf.

📒 Files selected for processing (1)
  • hack/e2e.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test

@kvaps kvaps merged commit fcc7056 into main Apr 25, 2025
6 checks passed
@kvaps kvaps deleted the fix-rc-helmchart branch April 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants