[monitoring] fix vpa for vmagent delete resources #820

klinch0 · 2025-04-17T18:38:20Z

Summary by CodeRabbit

Chores
- Updated resource allocation settings for monitoring agents by removing predefined CPU and memory limits.
- Added an option to specify separate resource settings for the config reloader component.

Signed-off-by: kklinch0 <kklinch0@gmail.com>

coderabbitai · 2025-04-17T18:38:29Z

Walkthrough

The changes simplify the resource allocation configuration for the vmagent Kubernetes resource by removing explicit CPU and memory requests and limits, replacing them with empty resource definitions. Additionally, a new empty resource field for the config reloader component is introduced. No other modifications to the configuration or structure are present.

Changes

File(s)	Change Summary
packages/system/monitoring-agents/templates/vmagent.yaml	Removed explicit CPU and memory resource requests/limits; added empty `resources` and `configReloaderResources` fields.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Kubernetes
    participant vmagent
    participant ConfigReloader

    User->>Kubernetes: Apply vmagent.yaml
    Kubernetes->>vmagent: Deploy with empty resources
    Kubernetes->>ConfigReloader: Deploy with empty configReloaderResources

Possibly related PRs

[monitoring] add vpa for vmagent #772: Modifies resource-related settings for vmagent, including Vertical Pod Autoscaler configuration and shardCount, which is related to resource management changes in this PR.

Suggested reviewers

kvaps

Poem

A hop and a skip through the YAML we go,
Resource constraints vanish, the limits run low.
With empty fields waiting for what may appear,
ConfigReloader joins in, its slate now clear.
The cluster breathes easy, no bounds set in stone—
A rabbit’s delight in a spec overthrown! 🐇

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/system/monitoring-agents/templates/vmagent.yaml (1)

24-24: Introduce empty configReloaderResources block
Adding configReloaderResources: {} follows the same pattern for the config‑reloader sidecar. Consider documenting why it’s intentionally empty to aid future maintainers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acbfb6a and 4e9446d.

📒 Files selected for processing (1)

packages/system/monitoring-agents/templates/vmagent.yaml (1 hunks)

🔇 Additional comments (1)

packages/system/monitoring-agents/templates/vmagent.yaml (1)

23-23: Empty resources to enable VPA-driven scaling
Replacing the previous hard‑coded CPU/memory requests and limits with resources: {} is the right approach to let the Vertical Pod Autoscaler manage sizing automatically.

Please verify that the VMAgent CRD accepts an empty resources block and that your VPA configuration targets the correct container. It’s recommended to test this in a staging environment and confirm that the VPA recommendations are applied as expected.

kvaps

LGTM

## Summary by CodeRabbit - **Chores** - Updated resource allocation settings for monitoring agents by removing predefined CPU and memory limits. - Added an option to specify separate resource settings for the config reloader component.

klinch0 requested review from kvaps and lllamnyp as code owners April 17, 2025 18:38

[monitoring] fix vpa for vmagent delete resources

4e9446d

Signed-off-by: kklinch0 <kklinch0@gmail.com>

klinch0 force-pushed the (monitoring)--fix-vpa-for-vmagent-delete-resources branch from adc253a to 4e9446d Compare April 17, 2025 18:38

coderabbitai bot reviewed Apr 17, 2025

View reviewed changes

kvaps approved these changes Apr 17, 2025

View reviewed changes

kvaps merged commit 53cbb4a into main Apr 17, 2025
5 of 6 checks passed

kvaps deleted the (monitoring)--fix-vpa-for-vmagent-delete-resources branch April 17, 2025 21:16

coderabbitai bot mentioned this pull request Jun 26, 2025

[platform] rm kk memory limit #1122

Merged

NickVolynkin mentioned this pull request Jul 24, 2025

Platform reliability/recilience improvements #1253

Open

coderabbitai bot mentioned this pull request Aug 4, 2025

[test] fix vm tests #1308

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[monitoring] fix vpa for vmagent delete resources #820

[monitoring] fix vpa for vmagent delete resources #820

Uh oh!

klinch0 commented Apr 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 17, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

kvaps left a comment

Uh oh!

Uh oh!

Uh oh!

[monitoring] fix vpa for vmagent delete resources #820

[monitoring] fix vpa for vmagent delete resources #820

Uh oh!

Conversation

klinch0 commented Apr 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

kvaps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

klinch0 commented Apr 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)