fix: Reconnect realtime after refreshed token #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a good one: after a token refresh made by cozy-client, the handler `onClientTokenRefreshed` is called. It is supposed to reconnect, as mentioned in the function comments. However, probably due to exhaustion or evil clipboard, the realtime was **revoked** rather than reconnected. This was probably causing the realtime failures that we noticed before without spotting the source.
8a8bf11 to
97110b8
Compare
Ldoppea
approved these changes
Feb 7, 2025
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Feb 11, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 11, 2025
`cozy-realtime` has been upgraded to `5.6.4` in order to retrieve a fix on refreshToken mechanism that would break the realtime stream Related PR: cozy/cozy-libs#2731
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 11, 2025
`cozy-realtime` has been upgraded to `5.6.4` in order to retrieve a fix on refreshToken mechanism that would break the realtime stream Related PR: cozy/cozy-libs#2731
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
`cozy-realtime` has been upgraded to `5.6.4` in order to retrieve a fix on refreshToken mechanism that would break the realtime stream Related PR: cozy/cozy-libs#2731
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
`cozy-realtime` has been upgraded to `5.6.4` in order to retrieve a fix on refreshToken mechanism that would break the realtime stream Related PR: cozy/cozy-libs#2731
paultranvan
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 20, 2025
paultranvan
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 20, 2025
zatteo
pushed a commit
to cozy/cozy-drive
that referenced
this pull request
May 21, 2025
JF-Cozy
pushed a commit
to cozy/cozy-drive
that referenced
this pull request
Jun 26, 2025
JF-Cozy
pushed a commit
to cozy/cozy-drive
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good one: after a token refresh made by cozy-client, the handler
onClientTokenRefreshedis called.It is supposed to reconnect, as mentioned in the function comments. However, probably due to exhaustion or evil clipboard, the realtime was revoked rather than reconnected.
This was probably causing the realtime failures that we noticed before without spotting the source.