Skip to content

fix(ErrorShare): Reduce icon height from 8rem to 2rem #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

fix(ErrorShare): Reduce icon height from 8rem to 2rem #3396

merged 1 commit into from
Jun 12, 2025

Conversation

lenhanphung
Copy link
Contributor

No description provided.

@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 12, 2025

BundleMon

Files updated (2)
Status Path Size Limits
✅ static/js/cozy.(hash).js
 741.96KB (+28B 0%) -
✅ public/static/js/public.(hash).js
 84.38KB (+15B +0.02%) -
Unchanged files (19)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 1.08MB -
✅ public/static/js/(chunkId).(hash).js
 852.98KB -
✅ public/static/js/cozy.(hash).js
 603.48KB -
✅ (hash).js
 337.62KB -
✅ public/(hash).js
 337.62KB -
✅ services/qualificationMigration.js
 273.84KB -
✅ services/dacc.js
 256.78KB -
✅ static/js/main.(hash).js
 115.8KB -
✅ public/static/js/lib-react.(hash).js
 39.37KB -
✅ static/js/lib-react.(hash).js
 39.37KB -
✅ public/static/css/cozy.(hash).css
 33.73KB -
✅ static/css/cozy.(hash).css
 33.73KB -
✅ public/static/js/lib-router.(hash).js
 22.05KB -
✅ static/js/lib-router.(hash).js
 22.05KB -
✅ static/css/main.(hash).css
 16.28KB -
✅ public/static/css/public.(hash).css
 5.63KB -
✅ manifest.webapp
 1.89KB -
✅ index.html
 688B -
✅ assets/manifest.json
 185B -

Total files change +42B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.34MB (+47B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.15MB -
✅ **/*.css
 128.42KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

JF-Cozy
JF-Cozy approved these changes Jun 12, 2025
View reviewed changes
src/components/Error/ErrorShare.jsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try icon={<Icon icon={CloudBrokenIcon} size="XXX" or height="XXX" />}? Is it working? Otherwise ok for your approach 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JF-Cozy it works as expected. Im using componentProps because parent component is designed to handle icon props this way, but your way seems more flexible and direct to the way of rendering icons 🤔
I will keep your solution for same case in future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I think when you have 5min without rush, you can modify and push without review :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next push will include this :D

@lenhanphung lenhanphung merged commit 5d4cf14 into master Jun 12, 2025
4 checks passed
@lenhanphung lenhanphung deleted the fix/error-share-icon-size branch June 12, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF-Cozy JF-Cozy JF-Cozy approved these changes

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenhanphung @JF-Cozy