Skip to content

feat(FileName): Don't load path component if not necessary #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

feat(FileName): Don't load path component if not necessary #3382

merged 1 commit into from
May 22, 2025

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented May 22, 2025

Passing a comp returning null as props is not the same than passing
directly undefined, because if we test the prop inside the comp,
first way will return true, second way will return false

@JF-Cozy
feat(FileName): Don't load path component if not necessary
fb10d15 
Passing a comp returning null as props is not the same than passing
directly undefined, because if we test the prop inside the comp,
first way will return true, second way will return false
@bundlemon BundleMon
Copy link

bundlemon bot commented May 22, 2025

BundleMon

Files updated (1)
Status Path Size Limits
✅ static/js/main.(hash).js
 115.78KB (+22B +0.02%) -
Unchanged files (20)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 1.09MB -
✅ public/static/js/(chunkId).(hash).js
 868.83KB -
✅ static/js/cozy.(hash).js
 737.43KB -
✅ public/static/js/cozy.(hash).js
 598.17KB -
✅ (hash).js
 337.62KB -
✅ public/(hash).js
 337.62KB -
✅ services/qualificationMigration.js
 273.84KB -
✅ services/dacc.js
 256.78KB -
✅ public/static/js/public.(hash).js
 84.58KB -
✅ public/static/js/lib-react.(hash).js
 39.37KB -
✅ static/js/lib-react.(hash).js
 39.37KB -
✅ public/static/css/cozy.(hash).css
 33.72KB -
✅ static/css/cozy.(hash).css
 33.72KB -
✅ public/static/js/lib-router.(hash).js
 22.05KB -
✅ static/js/lib-router.(hash).js
 22.05KB -
✅ static/css/main.(hash).css
 16.26KB -
✅ public/static/css/public.(hash).css
 5.61KB -
✅ manifest.webapp
 1.89KB -
✅ index.html
 690B -
✅ assets/manifest.json
 185B -

Total files change +20B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.35MB (+43B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.15MB -
✅ **/*.css
 128.36KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 146a9d8 into master May 22, 2025
4 checks passed
@JF-Cozy JF-Cozy deleted the fix/pathname branch May 22, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

@lenhanphung lenhanphung Awaiting requested review from lenhanphung lenhanphung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JF-Cozy