Add new viztualized table with dragndrop #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JF-Cozy merged 20 commits into master from feat/FRONT-1306-new-wip

May 22, 2025

Contributor

JF-Cozy commented May 21, 2025 •

edited

Loading

This is the first iteration, so maybe we will have to adjust thing after using it.

Limitations :

Feature only available on desktop for now
need to set drive.virtualization.enabled flag to enable the feature
DragnDrop only enabled on /folder views

thanks to @Merkur39 too ❤️

zatteo reviewed

View reviewed changes

src/modules/filelist/virtualized/cells/Cell.jsx Outdated Show resolved Hide resolved

zatteo reviewed

View reviewed changes

src/modules/filelist/virtualized/cells/FileName.jsx Outdated Show resolved Hide resolved

zatteo reviewed

View reviewed changes

src/modules/views/Folder/virtualized/FolderViewBody.jsx Show resolved Hide resolved

zatteo reviewed

View reviewed changes

src/modules/views/Folder/virtualized/helpers.js Outdated Show resolved Hide resolved

zatteo reviewed

View reviewed changes

src/modules/upload/Dropzone.jsx Show resolved Hide resolved

Member

zatteo commented May 22, 2025 •

edited

Loading

Can't wait to try it! 🎉

2 general questions :

what is needed for a mobile version?
between cozy-ui and here I saw a lof of memo, did you check the memory usage with lot of data ?

JF-Cozy and others added 16 commits

May 22, 2025 10:48


          feat: Upgrade cozy-ui

50ff1f3


          feat: Upgrade why-did-you-render

d0d244b


          refactor: Extract CertificationsIcons comp from FileName

627c792

no code change


          feat(FileOpener): Disable long press to deselect row

cfb2351

Remove useless prop for useLongPress


          refactor(FileIconMime): Rename comp correctly

975f6ec


          refactor(FileThumbnail): Use u-classes instead of Mui props

fc8b6bd


          feat: Add style props on FilenameInput and RenameInput

dcee990


          feat: Add getDriveI18n to use local in simple js function

6115b97


          feat(SelectionProvider): Add selectAll value

fd60d9a


          feat: Add new virtualized table components

1e1740c


          feat: Add virtualized table behind feature flag

550cbec

on folder, sharing, trash and recent view


          refactor(Dropzone): Reorganize code to better understanding

13ab70d

no code change


          refactor(Dropzone): Replace HOC by hooks

faf1113

no code change


          refactor(Dropzone): Use func comp instead of obj comp

3e20328

no code change


          feat: Add react-dnd and react-dnd-html5-backend

27e023d


          feat: Add dragndrop on virtualized table

e621ea2

JF-Cozy force-pushed the feat/FRONT-1306-new-wip branch from 47f7c9a to e621ea2 Compare

May 22, 2025 09:00

bundlemon bot commented May 22, 2025 •

edited

Loading

BundleMon

Files updated (10)

Status	Path	Size	Limits
✅	static/js/(chunkId).(hash).js	1.09MB (+29.55KB +2.72%)	-
✅	public/static/js/(chunkId).(hash).js	868.83KB (+9.46KB +1.1%)	-
✅	static/js/cozy.(hash).js	737.44KB (+3.67KB +0.5%)	-
✅	static/js/main.(hash).js	115.76KB (+2.88KB +2.56%)	-
✅	public/static/js/cozy.(hash).js	598.18KB (+604B +0.1%)	-
✅	public/static/js/public.(hash).js	84.58KB (+358B +0.42%)	-
✅	public/static/css/cozy.(hash).css	33.72KB (+23B +0.07%)	-
✅	public/static/css/public.(hash).css	5.61KB (+23B +0.4%)	-
✅	static/css/cozy.(hash).css	33.72KB (+23B +0.07%)	-
✅	static/css/main.(hash).css	16.26KB (+23B +0.14%)	-

Unchanged files (11)

Status	Path	Size	Limits
✅	(hash).js	337.62KB	-
✅	public/(hash).js	337.62KB	-
✅	services/qualificationMigration.js	273.84KB	-
✅	services/dacc.js	256.78KB	-
✅	public/static/js/lib-react.(hash).js	39.37KB	-
✅	static/js/lib-react.(hash).js	39.37KB	-
✅	public/static/js/lib-router.(hash).js	22.05KB	-
✅	static/js/lib-router.(hash).js	22.05KB	-
✅	manifest.webapp	1.89KB	-
✅	index.html	688B	-
✅	assets/manifest.json	185B	-

Total files change +46.59KB +0.95%

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	6.35MB (+47.22KB +0.73%)	-
✅	*/.css	128.36KB (+136B +0.1%)	-

Unchanged groups (1)

Status	Path	Size	Limits
✅	*/.{png,svg,ico}	2.15MB	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

JF-Cozy marked this pull request as ready for review

May 22, 2025 09:06

JF-Cozy requested review from Ldoppea and lenhanphung as code owners

May 22, 2025 09:06

JF-Cozy added 3 commits

May 22, 2025 11:27


          refactor: FileName should not rely on attributes.displayedPath

3e42eec

see 7ed480a


          refactor: Extract FileNamePath for better visibility

13ad83f


          refactor: Move fn inside Cell to avoid using them unnecessarily

cc14de2


          refactor: Remove comment

029d3d6

Contributor Author

JF-Cozy commented May 22, 2025 •

edited

Loading

what is needed for a mobile version?

Talk to POs first I think, maybe we have to think about the all UX before 🤔 technically I didn't even look at this stage... need to breath first :p

between cozy-ui and here I saw a lof of memo, did you check the memory usage with lot of data ?

No not really, I checked the area repainted in the DOM and the overall performance sensations. Maybe we can remove some memo in the future

zatteo approved these changes

View reviewed changes

JF-Cozy merged commit b50d6de into master

4 checks passed

JF-Cozy deleted the feat/FRONT-1306-new-wip branch

May 22, 2025 10:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet