fix: Favorith path not working on mobile #3379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d7c0c9 to
0ca021f
Compare
BundleMonFiles updated (2)
Unchanged files (19)
Total files change +71B 0% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
approved these changes
May 21, 2025
| @@ -100,6 +100,11 @@ export const computePath = ( | |||
| case 'shortcut': | |||
| return `/external/${file._id}` | |||
| case 'directory': | |||
| // If we are in /favorites tab, we do not want it to appears in computed path | |||
There was a problem hiding this comment.
On mobile, if we are in /favorites tab... I think will be better to understand next time what we are talking about here.
To support routing in tabs that are not based on a folder (for example /sharings, /recent, /favorites), we used to duplicate every routes so that we can browse files and folders in /sharings or /recent. Here, we take advantage of /favorites routes to be broken to try another approach. When in the /favorites tab, we set every link to default folders (folder/:id) and files (folder/:id/file/:id) links. So we do not browse files and folders in /favorites/xxx route anymore. When clicking on a file or a folder : - browser back button goes back to /favorites - Drive navigation back button goes to folder higher in folder hierarchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support routing in tabs that are not based on a folder (for example /sharings, /recent, /favorites), we used to duplicate every routes so that we can browse files and folders in /sharings or /recent.
Here, we take advantage of /favorites routes to be broken to try another approach. When in the /favorites tab, we set every link to default folders (folder/:id) and files (folder/:id/file/:id) links. So we do not browse files and folders in /favorites/xxx route anymore.
When clicking on a file or a folder :