Replace useFileWithPath with simple query #3370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make own parentFolderPath. Modifying the file doc wasn't a good approach in the first place anyway.
we exclude the trashed file and trash folder from the queries because that what's was done in the hook `const resultData = (result.data || []).filter(file => file.dir_id !== TRASH_DIR_ID && file.trashed !== true)`
BundleMonFiles updated (2)
Unchanged files (19)
Total files change -275B -0.01% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
reviewed
May 7, 2025
zatteo
reviewed
May 7, 2025
zatteo
approved these changes
May 7, 2025
paultranvan
approved these changes
May 7, 2025
paultranvan
reviewed
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useFileWithPathanduseFilesQueryWithPathwere hooks that allowed, by querying the parent folder via the file'sdir_id, to retrieve the parent's path and add it to an attribute calledfile.displayedFolder. We wanted to modify them because there is the queryDefbuildParentsByIdsQuery([])in them, which is suboptimal and will request all docs (because empty array passed to getByIds query).Here, we rely on a simple query with a
whereclause that allows, through the stack, to directly retrieve a file with its path. From there, we create a simple method based on this path to determine the parent's path. Additionally, we avoid adding a 'virtual' attribute (file.displayedFolder) that is not on io.cozy.files.