Skip to content

Update packages and allow to change download link #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

Update packages and allow to change download link #3367

merged 5 commits into from
Apr 29, 2025

Conversation

zatteo
Copy link
Member

@zatteo zatteo commented Apr 29, 2025

No description provided.

zatteo added 4 commits April 29, 2025 09:04
@zatteo
refactor: Centralize download link creation
6baf784
@zatteo
feat: Allow to force a link to download desktop app
8780690 
For information this link does not support i18n contrary to default behavior.
@zatteo
feat: Open Banner link on new tab
d6c3b75 
- If it is a file, browser automatically closes this new tab and open a file download modal
- If it is a link, it avoids loosing current navigation
@zatteo
feat: Remove isTwakeTheme for pushClient components
b636fe3
@zatteo zatteo force-pushed the feat/change-download-link branch from b3b21fe to b636fe3 Compare April 29, 2025 07:04
@bundlemon BundleMon
Copy link

bundlemon bot commented Apr 29, 2025

BundleMon

Files updated (4)
Status Path Size Limits
✅ public/static/js/cozy.(hash).js
 680.23KB (+3.64KB +0.54%) -
✅ static/js/cozy.(hash).js
 816.64KB (+3.19KB +0.39%) -
✅ public/static/js/public.(hash).js
 85.33KB (-21B -0.02%) -
✅ static/js/main.(hash).js
 114.34KB (-111B -0.09%) -
Unchanged files (17)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 1.06MB -
✅ public/static/js/(chunkId).(hash).js
 859.38KB -
✅ (hash).js
 337.62KB -
✅ public/(hash).js
 337.62KB -
✅ services/qualificationMigration.js
 273.84KB -
✅ services/dacc.js
 256.78KB -
✅ public/static/js/lib-react.(hash).js
 39.37KB -
✅ static/js/lib-react.(hash).js
 39.37KB -
✅ public/static/css/cozy.(hash).css
 34.74KB -
✅ static/css/cozy.(hash).css
 34.74KB -
✅ public/static/js/lib-router.(hash).js
 22.05KB -
✅ static/js/lib-router.(hash).js
 22.05KB -
✅ static/css/main.(hash).css
 16.24KB -
✅ public/static/css/public.(hash).css
 5.59KB -
✅ manifest.webapp
 1.89KB -
✅ index.html
 687B -
✅ assets/manifest.json
 185B -

Total files change +6.7KB +0.13%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.53MB (+8.6KB +0.13%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.15MB -
✅ **/*.css
 131.37KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

zatteo added a commit to cozy/cozy-photos that referenced this pull request Apr 29, 2025
@zatteo
feat: Update Banner and Button to Twake style
5f48708 
Also use potential desktop download link from cozy-flag. Related to cozy/cozy-drive#3367
zatteo added a commit to cozy/cozy-photos that referenced this pull request Apr 29, 2025
@zatteo
feat: Update Banner and Button to Twake style
b8a8ad0 
Also use potential desktop download link from cozy-flag. Related to cozy/cozy-drive#3367
@zatteo zatteo merged commit aae1a8b into master Apr 29, 2025
4 checks passed
@zatteo zatteo deleted the feat/change-download-link branch April 29, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Ldoppea approved these changes

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

@lenhanphung lenhanphung Awaiting requested review from lenhanphung lenhanphung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zatteo @Ldoppea