refactor(UI): Replace trash icon with custom SVG asset #3345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the default trash icon from cozy-ui with a custom SVG asset in the Empty trash component to improve visual appearance. This change improves the user experience when viewing empty trash folder.
BundleMonFiles updated (3)
Unchanged files (18)
Total files change +2.24KB +0.04% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
approved these changes
Apr 1, 2025
src/components/Error/Empty.jsx
Outdated
| } | ||
|
|
||
| let iconToShow = EmptyIcon[type] | ||
| if (isTwakeTheme() && type !== 'trash') { |
There was a problem hiding this comment.
if we can use only isTwakeTheme() in the condition, it will be easier to simplify the code when we no longer need this condition (and then have to remove uesless code in few weeks)
Update the condition in Empty.jsx to only check isTwakeTheme() which makes the code cleaner and easier to remove when this condition is no longer needed.
JF-Cozy
reviewed
Apr 2, 2025
| @@ -27,7 +27,7 @@ const EmptyCanvas = ({ type, canUpload, localeKey, hasTextMobileVersion }) => { | |||
| const { isMobile } = useBreakpoints() | |||
|
|
|||
| let iconToShow = EmptyIcon[type] | |||
| if (isTwakeTheme() && type !== 'trash') { | |||
| if (isTwakeTheme()) { | |||
There was a problem hiding this comment.
I meant to use isTwakeTheme() only somehow 🤔 so by changing the code if necessary... do we have the same result here than before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the default trash icon from cozy-ui with a custom SVG asset in the Empty trash component to improve visual appearance.
This change improves the user experience when viewing empty trash folder.