Skip to content

Fix favorites #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

Fix favorites #3344

merged 3 commits into from
Apr 1, 2025

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Mar 31, 2025

No description provided.

@JF-Cozy
refactor: Use getViewerPath to generate FileViewer path
6f6bad1 
no code change really, it's exactly the same result
@JF-Cozy JF-Cozy requested review from zatteo and Ldoppea as code owners March 31, 2025 14:48
@bundlemon BundleMon
Copy link

bundlemon bot commented Mar 31, 2025 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ static/js/main.(hash).js
 126.21KB (+100B +0.08%) -
✅ public/static/js/public.(hash).js
 97.56KB (+73B +0.07%) -
✅ static/js/cozy.(hash).js
 896.21KB (-68B -0.01%) -
Unchanged files (18)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 1.05MB -
✅ public/static/js/(chunkId).(hash).js
 851.17KB -
✅ public/static/js/cozy.(hash).js
 759.97KB -
✅ (hash).js
 337.62KB -
✅ public/(hash).js
 337.62KB -
✅ services/qualificationMigration.js
 271.6KB -
✅ services/dacc.js
 254.54KB -
✅ public/static/js/lib-react.(hash).js
 39.37KB -
✅ static/js/lib-react.(hash).js
 39.37KB -
✅ public/static/css/cozy.(hash).css
 34.58KB -
✅ static/css/cozy.(hash).css
 34.58KB -
✅ public/static/js/lib-router.(hash).js
 22.05KB -
✅ static/js/lib-router.(hash).js
 22.05KB -
✅ static/css/main.(hash).css
 16.24KB -
✅ public/static/css/public.(hash).css
 5.59KB -
✅ manifest.webapp
 1.91KB -
✅ index.html
 687B -
✅ assets/manifest.json
 185B -

Total files change +99B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.67MB (+88B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.19MB -
✅ **/*.css
 130.95KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

zatteo
zatteo reviewed Apr 1, 2025
View reviewed changes
JF-Cozy added 2 commits April 1, 2025 08:55
@JF-Cozy
fix: Favorites path was broken
cf2da97 
The `useFileLink` hook works very well as long as it does not require changing routes to navigate into a folder. However, if, for example, from the `Recent` view you want to display a file that is normally accessible via the `Folder` route, it would crash.
@JF-Cozy
fix: NavItem wasn't selected properly when using favorites
4cd14af
@JF-Cozy JF-Cozy merged commit 832160a into master Apr 1, 2025
4 checks passed
@JF-Cozy JF-Cozy deleted the fix/favorites branch April 1, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JF-Cozy @zatteo