Feature/new UI drive #3340
Feature/new UI drive #3340
Conversation
There was a problem hiding this comment.
Very clean, clear, explicit, and pleasant PR to review, well done, good job! 😄 🎉
About the commit message, if you modify UX somehow, it's not a refactor but a feat. Fix are used if you fixed something from previous release only. There is not such thing as style.
src/modules/layout/Layout.jsx
Outdated
| return ( | ||
| <LayoutUI> | ||
| <BarComponent searchOptions={{ enabled: true }} disableInternalStore /> | ||
| <FlagSwitcher /> | ||
| <Sidebar className="u-flex-justify-between"> | ||
| {folderId ? ( |
There was a problem hiding this comment.
be careful the all modification on this commit is not behind a isTwakeTheme()... Maybe it's not a big deal, I suggest you to ask @poupotte (Zoé), maybe it's ok to do the modification on Cozy side too.
There was a problem hiding this comment.
@poupotte can you help me leave some cmt? or what is your twake chat ID?
| label="trash" | ||
| rx={/\/trash(\/.*)?/} | ||
| clickState={clickState} | ||
| /> |
There was a problem hiding this comment.
we "recently" did the strict opposite of this commit. Did you knew ? Maybe this way is the right way to do it, maybe we missed something, I let you judge on that
There was a problem hiding this comment.
src/components/Button/MoreButton.jsx
Outdated
There was a problem hiding this comment.
CircleButton is not meant to be used like this... but if the result is as expected, why not! FYI you have some circle button example in https://docs.cozy.io/cozy-ui/react/#/Buttons chapter "Icons"
Update both desktop and mobile versions of file header Modify header cell styling to enhance user experience
Create new ViewSwitcher component for toggling between view modes Integrate component into Toolbar and Drive folder view Add translations for the new component in English and French
Fix conflicts between branches and ensure code consistency
Relocated trash functionality from the files list to the sidebar navigation for better user experience and cleaner file view
Improved mobile experience by updating the add menu button across multiple components and adding necessary translations
Update 3-dots action buttons appearance with rounded hover style next to share button and in table action column
Add missing translations for SelectionBar component across multiple languages
Shortened text labels in mobile version for better UI/UX in limited screen space
Apply PR feedback: use isTwakeTheme directly, rename class to fil-content-header--capitalize, fix object formatting, use hook provider for thumbnail controls
Implement changes requested in PR: replace refactor with feat type, use isTwakeTheme() directly, rename u-capitalize to fil-content-header--capitalize, fix object formatting, use hook provider for thumbnail controls instead of props
Resolve code style and formatting issues flagged by linter
Replace direct t prop passing with useI18n() hook in makeComponent function for better code organization
1d218dd to
6022561
Compare
by removing failing on console
BundleMonFiles updated (7)
Unchanged files (14)
Total files change +3.96KB +0.08% Groups updated (2)
Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Key Changes
Updated header design for both desktop and mobile versions
Refined header cell styling for better display
Enhanced user experience with the new interface
Created a new ViewSwitcher component allowing users to toggle between view modes
Integrated the component into the Toolbar and Drive folder view
Added English and French translations for the new feature
Restructured the add button position to improve usability
Updated related layout components to accommodate the new position
Updated all translations in supported languages